[Refactor]: replace ai-assistant model config file with ts for npm availability - #3154
Merged
Merged
Conversation
Collaborator
|
Thank you, @holahmide ! The solution looks good to me. Can you solve the conflicts since there is an updated models.json file: https://github.com/keplergl/kepler.gl/blob/master/src/ai-assistant/src/config/models.json? Let me know if you need any assistance. |
…ailability Signed-off-by: Olamide Adeniyi <olami02bj@gmail.com>
holahmide
force-pushed
the
refactor/json-to-ts-config
branch
from
July 9, 2025 01:03
98d5b19 to
daa2892
Compare
Contributor
Author
|
Thanks @lixun910! I have fixed the conflicts. |
lixun910
approved these changes
Jul 9, 2025
igorDykhta
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The new AI-assistant feature added a runtime import of config/models.json. While the file exists in the repository, it is excluded from the published npm package, so any downstream project
(npm install kepler.gl)fails to build with:Module not found: Error: Can't resolve 'config/models.json'What this PR does?
Replaces config/models.json with a strongly-typed config/models.ts module.
Updates all imports to reference the new TypeScript file (import models from 'config/models').